-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-quicksight): quicksight generated Python is really huge could it be smaller? #4066
Comments
Thanks for reporting this @jeffb4, This is going to be related to jsii, I'm going to transfer this issue to that repository, let's see what they say 🙂 |
This service has a very large TypeScript definition and we wouldn't really be able to reduce its size without removing functionality. Saying that, the jsii package is aggravating this issue to a much larger problem than it is in TS. |
I see it already. This file is ginormous because of the automatically generated code examples. The example for |
Not sure this is going to help enough. The file is 900k lines, and the big examples are only 30k lines. |
Describe the feature
This isn't a bug, but the size of the quicksight Python code is very large and breaks in vscode's default python server
I confirmed that yeah, that's a beefy boi
Use Case
I don't think the python language server would be able to by default show typing hints etc for that module, which would be great.
Proposed Solution
I understand the Python is generated with jsii from typescript sources - I don't know if the typescript source file is huge and could be shrunk down, or if the conversion is particularly inefficient.
Other Information
No response
Acknowledgements
CDK version used
aws-cdk-lib 2.73.0
Environment details (OS name and version, etc.)
Linux docker-desktop 5.15.49-linuxkit aws/aws-cdk#1 SMP Tue Sep 13 07:51:46 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
The text was updated successfully, but these errors were encountered: