Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running CTA without porting enabled still makes changes to project CS files. #190

Open
ShanshanHe opened this issue Aug 13, 2021 · 0 comments

Comments

@ShanshanHe
Copy link
Contributor

Describe the bug

When running CTA.SolutionPort.Run without porting the code (through setting PortCoreConfiguration.PortCode and PortCoreConfiguration.PortProject to False, CTA applies NormalizeWhitespace on the source file root node aggressively and overwrites the source file with the normalized version.

Expected behavior

CTA should not make any modification to the source code when porting is disabled.

Steps to Reproduce

Steps to reproduce the behavior:

  1. On your local CTA dev environment, change PortCode and PortProject here to false
  2. Build CTA and run PortCoreCLI with the following arguments: --solution-path=<path//to//your//test_solution.sln> --use-builtin-rules=True
  3. Check the changes in the source code .cs files in test solution (A easier way to check the change is to have the test solution versioning controlled through git, and check git status after step 2).

Desktop (please complete the following information)

  • OS: Windows
  • Version:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant