Prepare for Ruby 3.4 release - add dependencies on previously default gems (base64/bigdecimal) #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jterapin
reviewed
Feb 12, 2024
| @@ -381,10 +387,7 @@ | |||
| "addPlugins": [ | |||
| "Aws::EC2::Plugins::CopyEncryptedSnapshot", | |||
| "Aws::EC2::Plugins::RegionValidation" | |||
| ], | |||
| "dependencies": { | |||
| "aws-sigv4": "~> 1.0" | |||
There was a problem hiding this comment.
I'm thinking that we are getting rid of the aws-sigv4 dependency here since it is already noted in the core, right? No reason to restate this dependency in both areas and etc.
There was a problem hiding this comment.
Not only is it a dependency in core - the codegen already separately adds it as a dependency: https://github.com/aws/aws-sdk-ruby/blob/version-3/build_tools/services.rb#L162
mullermp
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2984
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!