-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: aws-sdk not changed after converted #753
Labels
Comments
trivikr
added
bug
Something isn't working
enhancement
New feature or request
triage
Triaging bugs
p2
This is a standard priority issue
and removed
triage
Triaging bugs
bug
Something isn't working
labels
Mar 7, 2024
var endpoint = new AWS.Endpoint(domain); Feature Request: #694 |
trivikr
changed the title
[Bug?]: aws-sdk not changed after converted
[Feature]: aws-sdk not changed after converted
Mar 7, 2024
@mutongwu Where is the signer used in your sample code? I see only the following lines: var signer = new AWS.Signers.V4(request, "es");
signer.addAuthorization(credentials, new Date()); The Signers.V4 was removed from public interface aws/aws-sdk-js#1247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Self-service
Describe the bug
I'd like to update my nodejs version from 16.x to 18.x.
And when I run
npx aws-sdk-js-codemod -t v2-to-v3
, he statementvar AWS = require("aws-sdk");
not changed after converted.Steps to reproduce
source fie
output
Observed behavior
Expected behavior
require("aws-sdk"); should changed to something from '@aws-sdk/XXX' right?
And
AWS.Signers
,AWS.HttpRequest
,AWS.Endpoint
should changed relevantlyEnvironment
Additional context
No response
The text was updated successfully, but these errors were encountered: