Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local environment variables interfere with tests #8652

Open
j0ni opened this issue Apr 28, 2024 · 1 comment
Open

Local environment variables interfere with tests #8652

j0ni opened this issue Apr 28, 2024 · 1 comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue source-distribution cli v2 source distritbution related issues test

Comments

@j0ni
Copy link

j0ni commented Apr 28, 2024

Describe the issue

When running the test suite, if the AWS_PROFILE version is set to something locally reasonable, some tests fail.

I'd like to suggest going through the list of supported variables and unsetting all of them as part of a global test setup step - to ensure more repeatable builds. It also seems possible that this problem may cause local test success for developers where tests should really fail, as well as the reverse, which is the symptom I've encountered.

Additional Information/Context

This came up on the AUR - you can see the discussion on the AWS CLI project there.

CLI version used

2.15.40

Environment details (OS name and version, etc.)

Arch GNU/Linux, current, installed using AUR package (kernel 6.8.7)

@j0ni j0ni added needs-triage This issue or PR still needs to be triaged. source-distribution cli v2 source distritbution related issues labels Apr 28, 2024
@tim-finnigan tim-finnigan self-assigned this Apr 30, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 30, 2024
@tim-finnigan
Copy link
Contributor

Thanks for reaching out. From the linked discussion you shared it looks like this is the test that is failing. If there are any other details you want to share here please let us know. Otherwise, per discussion with the team this looks like a reasonable ask.

@tim-finnigan tim-finnigan added feature-request A feature should be added or improved. test p3 This is a minor priority issue and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Apr 30, 2024
@tim-finnigan tim-finnigan removed their assignment Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue source-distribution cli v2 source distritbution related issues test
Projects
None yet
Development

No branches or pull requests

2 participants