Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --boot-mode is lacking "uefi-preferred" option #8651

Closed
2 tasks
ypismerov-tmx opened this issue Apr 26, 2024 · 4 comments
Closed
2 tasks

The --boot-mode is lacking "uefi-preferred" option #8651

ypismerov-tmx opened this issue Apr 26, 2024 · 4 comments
Assignees
Labels
ec2 feature-request A feature should be added or improved. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@ypismerov-tmx
Copy link

Describe the feature

There are cases uefi-preferred has to be set up for AMI to be able to work with AWS metal instances (dedicated hosts).
It is currently missing. Only uefi and legacy-bios modes are supported by --boot-mode.
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ami-boot.html lists of currently supported boot modes.

Use Case

  1. To support all currently available boot mode options.
    2, To support creation of AMI images (via image-import) that can work with AWS metal systems (dedicated hosts).

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CLI version used

aws-cli/2.15.38 Python/3.11.8 Linux/5.14.0-362.24.1.el9_3.x86_64 exe/x86_64.rhel.9 prompt/off

Environment details (OS name and version, etc.)

Red Hat Enterprise Linux release 9.3 (Plow)

@ypismerov-tmx ypismerov-tmx added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2024
@tim-finnigan tim-finnigan self-assigned this Apr 29, 2024
@tim-finnigan
Copy link
Contributor

Hi @ypismerov-tmx thanks for reaching out. What specific CLI commands are you trying to use --boot-mode? Here are all of the ec2 commands for reference: https://awscli.amazonaws.com/v2/documentation/api/latest/reference/ec2/index.html.

From the EC2 service API models (used by both the AWS CLI and Boto3) it looks like uefi-preferred was added 14 months ago to BootModeValues:

image

(Here is a link to the commit. And it looks like this is the related line in the CLI CHANGELOG.)

You mentioned using 2.15.38 which is a recent version, so I would expect the --boot-mode support for uefi-preferred to be up to date. If you want to share your debug logs (with sensitive info redacted) by adding --debug to the command, that could help give more insight into the issue. Depending on the information we receive, we may need to reach out to the EC2 team to verify that their API models are up to date in regard to this parameter.

@tim-finnigan tim-finnigan added ec2 service-api This issue is due to a problem in a service API, not the SDK implementation. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 29, 2024
@ypismerov-tmx
Copy link
Author

ypismerov-tmx commented Apr 30, 2024 via email

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Apr 30, 2024
@tim-finnigan
Copy link
Contributor

Thanks for following up - yes from the import-image command documentation it looks like uefi-preferred is not supported:

image

(That option is still listed under "Possible values" because it is modeled to be used across other APIs/commands. But the note was added there for clarification.)

Here is the boot modes page in the VM Import/Export User Guide for more information.

Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ec2 feature-request A feature should be added or improved. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

2 participants