Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max-keys option is undocumented for s3api list-object-versions #8592

Closed
iainelder opened this issue Mar 22, 2024 · 2 comments
Closed

max-keys option is undocumented for s3api list-object-versions #8592

iainelder opened this issue Mar 22, 2024 · 2 comments
Assignees
Labels
bug This issue is a bug. closed-for-staleness documentation This is a problem with documentation. p3 This is a minor priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. s3

Comments

@iainelder
Copy link

Describe the issue

The list-object-versions documentation refers to max-keys in the descriptions of other options.

The max-keys option needs its own description and an example.

The max-items option is similar and so sometimes people come to GitHub to ask for how to make max-items act like max-keys.

Today those issues are the best documentation I can find for max-keys.

Links

@iainelder iainelder added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Mar 22, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Apr 16, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK added bug This issue is a bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. s3 p3 This is a minor priority issue needs-review This issue or pull request needs review from a core team member. and removed needs-triage This issue or PR still needs to be triaged. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Apr 16, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @iainelder, thanks for reaching out. There's a few different things going on here to result in this behavior.

The AWS CLI documentation generally will hide service pagination parameters in favor of its own parameters ( --max-items being one such parameter). There are plenty of examples of this, such as describe-instances hiding max-results, or list-roles hiding marker. This is done so that pagination using the CLI is normalized across services. However, the CLI doesn't actually stop those parameters from being sent, hence why max-keys is functional for the S3 operations.

As I'm sure you saw in the issues you linked, there's some weird behavior around operations with multiple paginatable keys. list-object-versions has three, seen here. In the event of multiple paginatable keys, --max-items only applies to the first in that list. So that's why we're in situation where this undocumented parameter is sometimes more useful than the pagination parameters we replaced it with.

We do already have a backlog item to better document this behavior by clarifying which response element is affected by --max-items. I've raised this issue with the team. Given that this is a duplicate issue, I'm going to close this in favor of the older issue (#2555). Hope that helps, and please let me know if you have any further questions.

@RyanFitzSimmonsAK RyanFitzSimmonsAK added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-review This issue or pull request needs review from a core team member. labels Apr 23, 2024
Copy link

github-actions bot commented May 3, 2024

Greetings! It looks like this issue hasn’t been active in longer than five days. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels May 3, 2024
@github-actions github-actions bot closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. closed-for-staleness documentation This is a problem with documentation. p3 This is a minor priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. s3
Projects
None yet
Development

No branches or pull requests

2 participants