New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(pipes-targets): Add Step functions target for EventBridge pipes #29665
Labels
@aws-cdk/aws-lambda
Related to AWS Lambda
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Comments
RaphaelManke
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 31, 2024
I will implement this target myself. |
This was referenced Apr 1, 2024
tim-finnigan
added
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Apr 1, 2024
Thanks for the feature request and looking forward to seeing your PR! |
tim-finnigan
added
p2
effort/medium
Medium work item – several days of effort
and removed
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
labels
Apr 1, 2024
1 task
mergify bot
pushed a commit
that referenced
this issue
May 14, 2024
### Issue #29665 Closes #29665 ### Reason for this change Step Function target is not supported yet by pipes-targets. ### Description of changes - Added step function as a pipes target. - I've decided to make the `invocationType` a required parameter, since this made the code clearer and make users aware of how they want the step function to be invoked. The [AWS::Pipes::Pipe PipeTargetStateMachineParameters](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-pipes-pipe-pipetargetstatemachineparameters.html) has this as an optional parameter (defaulting to Request-Response), which can lead the user unknowingly in a broken pipe, because cdk's StateMachines [default](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_stepfunctions.StateMachine.html#statemachinetype) to Standard Workflow, which is not compatible with Request-Response Invocation Type. - Currently there seems no way to prevent users from creating a pipe with an imported Standard StateMachine and InvocationType Request-Response as the stateMachineType cant be read (or I dont know how :D) ### Description of how you validated changes - Added unit tests - Added integration test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- I've talked with @RaphaelManke and he was fine for me opening up a PR (put him as a co-author nevertheless) :) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-lambda
Related to AWS Lambda
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Describe the feature
Add a implementation for the Step function target for EventBridge pipes in the
pipes-targets
module.Use Case
For feature completeness of the L2 pipes module this source is required
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
Environment details (OS name and version, etc.)
The text was updated successfully, but these errors were encountered: