New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-appsync): Add Enhanced Metrics configuration to CDK #29933
Comments
Hi @piotrmoszkowicz , thanks for requesting this feature and agreeing to volunteer for L2 contruct PR. It would be a helpful feature and there is already needed support by cloudformation. So please go ahead and feel free to submit the PR. |
Hi @khushail, done! Please take a look and help with review ;) |
Appreciate your efforts @piotrmoszkowicz . Team would be reviewing it. |
Hey! Can we start looking at the code review for the PR? We would like to use that one in production and it is already stable for 3 weeks. |
@piotrmoszkowicz , thanks for submitting the PR. I see that integ-test and snapshots needs to be added to the PR. Once those are added, a community reviewer will start the initial review followed by the maintainer review. If you need any help or guidance, please feel free to reach out on #contributing channel on cdk.dev slack. |
Describe the feature
AWS AppSync some time ago introduced enhanced monitoring (https://docs.aws.amazon.com/appsync/latest/devguide/monitoring.html -> Enhanced Metrics), which allows to collect metrics at resolver/operation/data source leve. It is added within the CloudFormation (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appsync-graphqlapi.html ->
EnhancedMetricsConfig
), so I think it would be great feature within CDK. I will be happy to implement it, maybe even within end of the week ;)Use Case
Ability to configure AWS AppSync with Enhanced Monitoring.
Proposed Solution
Add missing property to AppSync's L2 construct and map it properly to AWS CloudFormation.
Other Information
No response
Acknowledgements
CDK version used
2.138.0
Environment details (OS name and version, etc.)
MacOS Ventura
The text was updated successfully, but these errors were encountered: