Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow substitution of unsupported characters in tags with alternative character. #44

Open
skrausedxccom opened this issue Apr 27, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@skrausedxccom
Copy link

according the documentation, Forward-Slash can be used for AWS/EC2 metrics. But AWS EC2 tagging does not allow foward slash.

@knizami
Copy link
Contributor

knizami commented May 4, 2023

Hello, thanks for creating this issue. I believe forward slashes are allowed unless tag retrieval via instance metadata is being used:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html#work-with-tags-in-IMDS

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html#tag-restrictions

I have updated the issue so that the solution will allow you to provide a dictionary for character substitutions. For example, provided a dictionary:

substitution_map = { '@': '\' }

The solution will create the alarm substituting the '@' sign found in the tag with a '' before processing the tag:

@knizami knizami changed the title Forward-Slash must not be used Allow substitution of unsupported characters in tags with alternative character. May 4, 2023
@knizami knizami self-assigned this May 4, 2023
@knizami knizami added the enhancement New feature or request label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants