Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: adopt AppConfig L2 constructs in Parameters integration tests #2396

Closed
1 of 2 tasks
dreamorosi opened this issue Apr 18, 2024 · 2 comments · Fixed by #2524
Closed
1 of 2 tasks

Maintenance: adopt AppConfig L2 constructs in Parameters integration tests #2396

dreamorosi opened this issue Apr 18, 2024 · 2 comments · Fixed by #2524
Assignees
Labels
completed This item is complete and has been merged/shipped good-first-issue Something that is suitable for those who want to start contributing tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

Summary

AWS CDK has added L2 constructs for AWS AppConfig that allow to create AppConfig resources more easily.

The AppConfig Provider part of the Parameters utility uses L1 constructs that are more verbose and require explicit management of dependencies between entities.

We should replace the existing construct with the newer.

Why is this needed?

So that the integration tests for the Parameters utility can become a little less verbose and less brittle.

Which area does this relate to?

Tests

Solution

Replace the code found here with the L2 constructs.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added good-first-issue Something that is suitable for those who want to start contributing help-wanted We would really appreciate some support from community for this one internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation tests PRs that add or change tests and removed internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Apr 18, 2024
@daschaa
Copy link
Contributor

daschaa commented May 14, 2024

I would like to take this issue ❤️

Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed help-wanted We would really appreciate some support from community for this one confirmed The scope is clear, ready for implementation labels May 15, 2024
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped good-first-issue Something that is suitable for those who want to start contributing tests PRs that add or change tests
Projects
2 participants