Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velero: Unable to use a nested prefix, nor override it by setting it myself in values #307

Open
boatmisser opened this issue Nov 8, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@boatmisser
Copy link

boatmisser commented Nov 8, 2023

Description

In the velero template there are a LOT of defaults populated via the set list.
One of these is the prefix which is taken from the s3_backup_location using a split on /.
This is coded to only take the first result, so any nested prefix is truncated e.g. 'foo/bar' becomes foo.
This would not be a problem except that I cannot override it by setting it myself in the values; it keeps creating it using the result of the split.
Can we either allow the prefix to be more than one level deep; or provide a way to override, or to switch off, the use of the set so I can do it myself.

I used to be able to do this in the previous version of blueprints v4.32.1 !

If your request is for a new feature, please use the Feature request template.
I don't consider this a feature request at this time as the blueprint should at the very least provide a method to override the default method of specifying the prefix.

  • [ x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

  • Module version [Required]: 1.11.0

  • Terraform version: 1.6.3

Reproduction Code [Required]

enable_velero = true
  velero        = {
    s3_backup_location = "arn:aws:s3:::${data.aws_caller_identity.current.account_id}-software-platforms/foo/bar"
    values             = [templatefile("${path.module}/helm_values/velero.yaml", {
      prefix                    = "foo/bar"
    })]

velero.yaml

configuration:
  backupStorageLocation:
    prefix: ${prefix}

Result is always:

objectStorage:
    bucket: XXXXXXXXXXXX-software-platforms
    prefix: foo

Expect:

objectStorage:
    bucket: XXXXXXXXXXXX-software-platforms
    prefix: foo/bar

Steps to reproduce the behaviour:

Try to install velero with a nested prefix (i.e. a prefix containing a /); either via s3_backup_location or values.

Expected behaviour

Either the prefix should include my entire value e.g. foo/bar OR I should be able to override the generated prefix via the values OR have the ability to off the set entirely.

Actual behaviour

My prefix is stripped so I end up with foo instead of foo/bar AND I cannot override it via values.

Terminal Output Screenshot(s)

N/A

Additional context

N/A

@boatmisser boatmisser changed the title Velero: Unable to use a nested prexix, nor override it by setting it myself in values Velero: Unable to use a nested prefix, nor override it by setting it myself in values Nov 8, 2023
@bryantbiggs bryantbiggs added this to the v2.0 milestone Nov 10, 2023
@github-actions github-actions bot added the stale label Dec 11, 2023
@aws-ia aws-ia deleted a comment from github-actions bot Dec 11, 2023
@bryantbiggs bryantbiggs removed the stale label Dec 11, 2023
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 11, 2024
Copy link

Issue closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 21, 2024
@bryantbiggs bryantbiggs reopened this Jan 23, 2024
@bryantbiggs bryantbiggs removed the stale label Jan 23, 2024
@askulkarni2 askulkarni2 added the bug Something isn't working label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants