Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSGoogleSignIn upgrade to GoogleSignIn 7.0.0 or newer #4827

Open
BillBunting opened this issue Jul 12, 2023 · 1 comment
Open

AWSGoogleSignIn upgrade to GoogleSignIn 7.0.0 or newer #4827

BillBunting opened this issue Jul 12, 2023 · 1 comment
Labels
auth feature-request Request a new feature

Comments

@BillBunting
Copy link
Contributor

Which AWS Services is the feature request for?
AWSGoogleSignIn

Requesting an upgrade and refactor
Upgrade (refactor) AWSGoogleSignIn from using GoogleSignIn 5.x.x to 7.0.0 (or newest)

Currently, AWSGoogleSignIn requires and works with pod GoogleSignIn 5.0.2. I'd like it refactored and upgraded to work with pod GoogleSignIn 7.0.0 (or newest) to remain current. Google API changes require a refactor.

(The Google header files are currently copied into AWSGoogleSignIn, but a pod dependency is preferred for consideration during a refactor to upgrade to the latest Google Sign In API, similar to how AWSFacebookSignIn includes FBSDKLoginKit)

My pod file is as follows:
pod 'GoogleSignIn', '~>5.0.2'
pod 'AWSCore', '= 2.33.0'
pod 'AWSUserPoolsSignIn', '= 2.33.0'
pod 'AWSAuthUI', '= 2.33.0'
pod 'AWSPinpoint', '= 2.33.0'
pod 'AWSS3', '= 2.33.0'
pod 'AWSDynamoDB', '= 2.33.0'
pod 'AWSAuthCore', '= 2.33.0'
pod 'AWSAPIGateway', '= 2.33.0'
pod 'AWSMobileClient', '= 2.33.0'
pod 'AWSGoogleSignIn', '= 2.33.0'
pod 'AWSFacebookSignIn', '= 2.33.0'
pod 'AWSAppleSignIn', '= 2.33.0'

Ideally, I'd like to use pod 'GoogleSignIn', '~>7.0.0'

@harsh62 harsh62 added the auth label Jul 13, 2023
@harsh62
Copy link
Member

harsh62 commented Jul 13, 2023

@BillBunting Thanks for raising the issue. Our team will look into this and will provide an update on the issue.

@phantumcode phantumcode added the feature-request Request a new feature label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

3 participants