Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Variant throws a javascript error. #537

Open
addgod opened this issue Feb 9, 2021 · 1 comment
Open

Make Variant throws a javascript error. #537

addgod opened this issue Feb 9, 2021 · 1 comment

Comments

@addgod
Copy link

addgod commented Feb 9, 2021

Describe the bug
Uncaught (in promise) TypeError: Cannot read property 'success' of undefined

It seems like there is no notification system added into the vue instance in the admin panel. This is used quite a few places, but when ever it is called it will fail.

Its seems also the notification system is used quite a few places, so this must generate an error in all instancs.

To Reproduce

  1. Go to 'Products'
  2. Add or find a VARIABLE_PRODUCT
  3. Click on 'Attributes'
  4. Click on 'Make variation'
  5. See error in console.

Screenshots
Screenshot from 2021-02-09 22-55-39

Additional context
Generally it also seems like a very bad idea that the variations are generated in all possible combinations. This is a horrible experience if you have eg. loads of colors. But only want one of two for a particular product.

@indpurvesh
Copy link
Member

@addgod will work on both the cases that
You have mentioned. Thanks for raising the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants