Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local icons don't override Avo's icons #2761

Closed
4 of 5 tasks
adrianthedev opened this issue May 9, 2024 · 0 comments · Fixed by #2783
Closed
4 of 5 tasks

Local icons don't override Avo's icons #2761

adrianthedev opened this issue May 9, 2024 · 0 comments · Fixed by #2783
Assignees
@gabrielgiroe1
Labels
Edge case It's not really a bug but an edge-case that might pop up from time to time. Fix

Comments

@adrianthedev
Copy link
Collaborator

adrianthedev commented May 9, 2024 •
edited by gabrielgiroe1

Feature

This requirement started from here #2729.

Approach

  • all our icons should have the heroicons prefix. So all svg "edit" type of declarations should become svg "heoricons/outline/edit"
  • the non-heroicons svgs must be moved inside an avo directory (svg "three-dots" beocmes svg "avo/three-dots")
  • add a rubocop rule that checks any svg("NOT_HEORICONS... or svg "NOT_HEROICONS... to raise an error.
  • in this PR we should not do any other refactor so we can review it easy
  • we must also check the other avo-* repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielgiroe1 gabrielgiroe1

Labels
Edge case It's not really a bug but an edge-case that might pop up from time to time. Fix
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use prefixes with SVGs so they won't clash with the parent app's avo-hq/avo
2 participants
@adrianthedev @gabrielgiroe1