Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argument order is in consistent in refund handle call in worker. #60

Open
pkrawat1 opened this issue Dec 28, 2017 · 0 comments
Open

argument order is in consistent in refund handle call in worker. #60

pkrawat1 opened this issue Dec 28, 2017 · 0 comments
Assignees
@oyeb
Labels
effort1: easy(hours) hotlist: core-team severity: medium type: refactor
Projects
Gringotts [low-hanging-fruit]
Milestone
1.2.0

Comments

@pkrawat1
Copy link
Member

standard we have followed in all the calls is id, amount, config but this is not followed in the refund method of the worker.ex file.

Make changes in this format as per the standard.

This would require change in all the gateway files.
@oyeb oyeb added this to Need discussion in Gringotts [low-hanging-fruit] Jan 15, 2018
@oyeb oyeb self-assigned this Jan 25, 2018
@oyeb oyeb modified the milestones: 1.1.0-beta, 2.0.0-alpha Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyeb oyeb

Labels
effort1: easy(hours) hotlist: core-team severity: medium type: refactor
Projects
No open projects
Gringotts [low-hanging-fruit]
  
Need discussion
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@pkrawat1 @oyeb