Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the ESLint Suggestions API #281

Open
sindresorhus opened this issue Nov 23, 2019 · 2 comments
Open

Support the ESLint Suggestions API #281

sindresorhus opened this issue Nov 23, 2019 · 2 comments
Labels
enhancement help wanted

Comments

@sindresorhus
Copy link
Member

There have been many cases where we could not provide auto-fixers because it was either not safe or there were multiple possible fixes. The Suggestions API enables us to provide multiple fixes that can be manually chosen by a user in an editor.

We should go through existing rules with no auto-fixers or with incomplete auto-fixers and make them support the Suggestions API.
@sindresorhus
Copy link
Member Author

I suggest (pun intended) that we drop auto-fixer for the no-only-test and no-skip-test and instead implement suggestions for them. Auto-fixers for those can be annoying (xojs/vscode-linter-xo#78) when you have "fix on save" in an editor.

@novemberborn Thoughts?

@sindresorhus sindresorhus mentioned this issue Feb 17, 2020
Closed
@novemberborn
Copy link
Member

Agreed.

@sindresorhus sindresorhus mentioned this issue Apr 26, 2020
Open
4 tasks
@sindresorhus sindresorhus mentioned this issue Mar 18, 2021
Closed
edbrannin added a commit to edbrannin/eslint-plugin-ava that referenced this issue Mar 19, 2021
@edbrannin
Use suggestions API for no-only-test, no-skip-test
6aeafdb 
avajs#324
avajs#281 (comment)
@edbrannin edbrannin mentioned this issue Mar 19, 2021
Merged
@jpolo jpolo mentioned this issue Feb 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@novemberborn @sindresorhus