Add no-invalid-modifier-chain rule
#309
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Impressive start @KinectTheUnknown! What kind of feedback are you looking for at this stage? |
I just wanted to make sure that I'm on the right path as far as the goals and features of this rule and anything else that this rule should cover. Right now, I'm making several changes to make error messages more specific so I can implement suggestions/fixes. |
Yea I think so! |
|
@KinectTheUnknown Still interested in finishing this? |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Invalid Modifier Chain
Fixes #186
Description
Disallows invalid combinations, order, and name of test/hook modifiers
Progress:
Configurable OptionsWhitelist modifier names from being flaggedToo complicated to implement at this time(note: Properly deprecated rules aren't supported by
packagetests)References:
馃
IssueHunt Summary
Referenced issues
This pull request has been submitted to: