-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spurious "previous failures in test files that were not rerun" in watch mode #3295
Labels
bug
current functionality does not work as desired
Comments
novemberborn
added a commit
that referenced
this issue
Jan 28, 2024
The counters used absolute paths for the test files, but the clearing logic used relative paths. Count using relative paths instead. The number of previous failures is not observable to the test harness, so this does not come with test coverage. Fixes #3295.
novemberborn
added a commit
that referenced
this issue
Jan 28, 2024
The counters used absolute paths for the test files, but the clearing logic used relative paths. Count using relative paths instead. The number of previous failures is not observable to the test harness, so this does not come with test coverage. Fixes #3295.
Thanks for the fast fix! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Actual
When AVA v6.1.0 runs in watch mode, it prints something like
4 previous failures in test files that were not rerun
on every rerun, counting all previously-failed tests from all previous runs, even after re-running all tests with 100% passing results.Expected
When AVA runs in watch mode, it should not report previous test failures. When all tests are passing, it should report that all tests are passing, full stop.
Reproduction
Minimal reproduction steps below, with annotations about observed behavior:
Touch
test.js
to let AVA re-run the test:Change
t.fail()
tot.pass()
and save:Type 'r' in the test console and hit enter to re-run tests:
The "previous failures" message never seems to clear. I can't figure out what it means or how it would be useful; all test files were rerun, and none had failures.
There are some previous reports of similar issues (#2821, #2069, #2040), but they've all been closed, and this still seems to happen in the current release.
The text was updated successfully, but these errors were encountered: