Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in thruster mapping not compatible with simulator. Patch required to take this as a CL argument. #107

Open
aniket11bh opened this issue Mar 21, 2016 · 3 comments
Labels

Comments

@aniket11bh
Copy link
Contributor

Why have you changed the thruster mappings ?

screenshot from 2016-03-21 21 41 21

@icyflame
Copy link
Member

@aniket11bh Apparently, it made PID work. I think this was during december testing, is it not working now? I remember thruster mappings were repeatedly changed during winter. @kalyan-kumar Remember anything from then?

@aniket11bh
Copy link
Contributor Author

The changed mapping is not suitable with the simulators, the previous one
is.

On Mon, Mar 21, 2016 at 9:59 PM, Siddharth Kannan [email protected]
wrote:

@aniket11bh https://github.com/aniket11bh Apparently, it made PID work.
I think this was during december testing, is it not working now? I remember
thruster mappings were repeatedly changed during winter. @kalyan-kumar
https://github.com/kalyan-kumar Remember anything from then?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#107 (comment)

Aniket Bhushan
3rd year Undergraduate ,
Manufacturing Science and Engineering
IIT Kharagpur

@icyflame
Copy link
Member

Hmm, that is a problem. Why not send a patch that takes a CLI argument to decide the thruster mapping? (Default will be the vehicle one of course, but just in case we want to run the simulator, we can pass in something like simulator after ./bin/exec-name.)

@icyflame icyflame changed the title 'Changes in thruster mapping in control_system_stack/setyaw/src/main.py Changes in thruster mapping not compatible with simulator. Patch required to take this as a CL argument. Mar 21, 2016
@icyflame icyflame added the bug label Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants