Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: add option for additional 2FA verification for elevated session #6963

Open
2 tasks done
ikiris opened this issue Mar 19, 2024 · 2 comments
Open
2 tasks done

FR: add option for additional 2FA verification for elevated session #6963

ikiris opened this issue Mar 19, 2024 · 2 comments
Labels
priority/4/normal Normal priority items status/needs-design Requires thoughtful design type/feature Request for adding a new feature

Comments

@ikiris
Copy link

ikiris commented Mar 19, 2024

Description

Email alone is not a useful security factor, if anything it is a hijack vulnerability for a compromised client (similar to SMS). This is a summarized version of some public hijackings like some of the icloud hijacks.

As such I have configured require 2fa and skip for elevated sessions. The problem is that require 2fa currently only requires the session to have been 2fa'd and not specifically requiring the elevated session and/or action requested to be 2fa'd. As a result, it is possible for a 3rd party to backdoor a client and add a 2fa token without requiring a 2fa hit if a backdoored client has an active 2fa SSO session.

The tldr request is to be able to require a 2fa verification specifically for the elevated session (or at least for the act of adding a 2fa token) instead of just accepting that there is an existing SSO session that was 2fa'd at its beginning.

Use Case

see description. TLDR this is a request to be able to require true physical 2fa verification to add additional 2fa tokens

Details

see description

Documentation

see description

Pre-Submission Checklist

  • I agree to follow the Code of Conduct

  • I have checked for related issues and checked the documentation

@ikiris ikiris added priority/4/normal Normal priority items status/needs-design Requires thoughtful design type/feature Request for adding a new feature labels Mar 19, 2024

This comment was marked as off-topic.

@james-d-elliott
Copy link
Member

Yeah no worries, we can add this if it's specifically for elevation of a session and would welcome a PR provided the integration tests cover it.

@james-d-elliott james-d-elliott changed the title FR: Require (or at least add option to) additional 2FA verification to add 2fa token if require 2fa configured for elevated session FR: add option for additional 2FA verification to add 2fa token if require 2fa configured for elevated session Mar 19, 2024
@james-d-elliott james-d-elliott changed the title FR: add option for additional 2FA verification to add 2fa token if require 2fa configured for elevated session FR: add option for additional 2FA verification for elevated session Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/4/normal Normal priority items status/needs-design Requires thoughtful design type/feature Request for adding a new feature
Projects
None yet
Development

No branches or pull requests

2 participants