New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
tab terminates the daemon when reconnecting to active sessions #313
Comments
Hi @liketechnik, More information would be helpful. Here are a few things I can think of:
A normal daemon startup looks like this in the command-line client logs:
If the client connects to a running daemon, it looks like this:
|
I now found a way to reliably force the behaviour to occur:
Doing this, I obtained the following log:
In comparsion, a normal startup, e. g. with no previously tab daemon running, yields the following log for
And the last case, tab successfully reusing an existing daemon:
Regarding the truncation, yes it does happen directly on tab invocation.
|
Ah! There is definitely something going on with the alacrity keybinding. I haven't set it up that way and I'm seeing weird behavior (the window quits when I try to select a session). What seems to happen there is that Alacritty sets the $SHELL env var with the contents of the It still wouldn't explain why the daemon quits though. I'm still looking at that. |
Also, thanks so much for all the info! It's super helpful 馃憤馃徎 |
Hey @liketechnik, |
I minimized the repro steps, and it's pretty easy to test:
The client is being reaped when it exits, which kills the daemon (as it technically is a zombie process). This happens because Alacritty calls Child::try_wait when the tab process exits (see source). The daemon is a child process of the client, so it's killed as a zombie. Looking into a fix. |
Hey @liketechnik, |
That's great news! Thank you for the fast fix. |
Hi,
first of all,
tab
is a really great piece of software, I favored using it instead oftmux
from the first moment I found (and used) it 馃憤Nevertheless, I have a really nasty problem with
tab
: Not always, but in many casestab
forcefully terminates the already running daemon, with sometimes still running applications in it, before connecting me to a session or presenting the fuzzy finder. I didn't find anything in the logs so far, although I noticed, when following the log file withtail -f
, that it's truncated on every restart of the daemon.I'm running version 0.5.5 installed with
cargo install tab
. I'm happy to provide any information needed to find the root issue of this problem.The text was updated successfully, but these errors were encountered: