Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new size values for width and height #30

Open
ausi opened this issue Oct 6, 2016 · 1 comment
Open

Support new size values for width and height #30

ausi opened this issue Oct 6, 2016 · 1 comment
Assignees
Labels

Comments

@ausi
Copy link
Owner

ausi commented Oct 6, 2016

Parent elements using width: fit-content should be skipped for example. Currently they can result in the circularity issue.

@ausi ausi added the bug label Oct 6, 2016
@ausi ausi self-assigned this Oct 6, 2016
@ausi ausi added this to To Do in Version 0.4.0 Jun 10, 2017
@ausi
Copy link
Owner Author

ausi commented Jun 11, 2017

This should be postponed until more browsers support these keywords. Implementing it now would decrease performance (because it needs the original style of the element) with little to no benefit.

Code for cq-prolyfill.js:1064:

var originalStyle = getOriginalStyle(element, prop);

// max-content, min-content and fit-content including prefixed versions
if (originalStyle && originalStyle.substr(-8) === '-content') {
	return true;
}

@ausi ausi removed this from To Do in Version 0.4.0 Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant