Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUESTION - New Widget - Drawer #796

Open
jlipford opened this issue Aug 12, 2019 · 7 comments
Open

QUESTION - New Widget - Drawer #796

jlipford opened this issue Aug 12, 2019 · 7 comments

Comments

@jlipford
Copy link

I am really interesting in integrating new widgets (like the Drawer). Is there a standard starting point that is advised? I understand the process of generating a pull request but was wondering if there was a standard way that the architects of this great bridge use to evaluate supporting new widgets.

@JeroenVinke
Copy link
Member

Hey @jlipford! Having Drawer support would be great 😄

We have a couple of resources:

I'm afraid we don't have a document describing the entire process of adding a new wrapper for a Kendo control to the bridge. Maybe @adriatic remembers if we made one?

The process we went through for adding new widgets looks like this (roughly):

  • get the development environment set up (instructions)
  • add a new .js file for the wrapper to a directory in the the src directory, similar to the others. I'd recommend using a control which has similar features as an example for your new wrapper
  • register the wrapper here
  • try to use the wrapper in this html file and this js file. When you run the sample application locally, you'll have a 'Test' page which then should display the Kendo control if everything went as planned

If everything works, you can create a pull request and @arnederuwe or I can take care of the release.

Please let us know if you have any issues/questions!

@adriatic
Copy link
Member

Hi, @JeroenVinke and @jlipford

The collection of articles in the folder https://aurelia-ui-toolkits-1.gitbook.io/kendoui-bridge-docs/bridge-developers-notes is to the best of recollections the information you would need. Since this information is almost three years old, it is quite possible that there might be some additional pieces of information that did not get added to it. I am pretty sure that all such details could be resolved "interactively" between @JeroenVinke @arnederuwe and yourself.

@JeroenVinke I am not sure whether this document covers the differences introduced by the only major improvement we did (delegating the definition of the list of the needed widgets to the app developer)

@jlipford
Copy link
Author

Seems like I have a recurring issue with jspm downloading github packages.
Seems to change each time i run jspm install...

"Bad Response code 401"

If I can swap out to npm packages its fine but for some that is not an option.

@jlipford
Copy link
Author

@adriatic Any help for the below jspm install error?

warn Error on download for github:aurelia-ui-toolkits/aurelia-after-attached-plugin
Bad response code 401

err Error downloading github:aurelia-ui-toolkits/aurelia-after-attached-plugin.

warn Installation changes not saved.

@JeroenVinke
Copy link
Member

JeroenVinke commented Aug 23, 2019 via email

@jlipford
Copy link
Author

@JeroenVinke thank you for the push! I still have no clue the issue as I just ended the .jspm/config file and removed the auth token, maybe I generated a bad token.

After that I rebased the proj and reinstalled jspm without issues and now the demo locally is working! Progress!

I am thinking the Menu is a good starting point for the drawer, let me know if you think there is better starting widget.

@JeroenVinke
Copy link
Member

JeroenVinke commented Aug 23, 2019

Great! I would have picked the menu as well. Let us know if you have any questions. Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants