Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

abt-breadcrumb needs to support route-href #77

Open
khuongduybui opened this issue Feb 11, 2019 · 4 comments
Open

abt-breadcrumb needs to support route-href #77

khuongduybui opened this issue Feb 11, 2019 · 4 comments
Assignees

Comments

@khuongduybui
Copy link

Besides feeding a string url directly to the breadcrumb item, we should have an option to provide an Aurelia router routing config. The item should look something like this:

{
  title: string,
  url?: string,
  config?: {
    route: string,
    params?: {}
  }
}
@shahabganji
Copy link
Contributor

@khuongduybui

Sorry for the late reply, I will try to create some time to make this happen within the next couple of weeks; till then, may I ask you to tell me more of what you expect in both view and view-model to be available?

@khuongduybui
Copy link
Author

Basically, I want to simply replace this

<ul class="navbar-nav mr-auto">
  <li repeat.for="route of router.navigation" class="nav-item ${row.isActive ? 'active' : ''}">
    <a href.bind="route.href" class="nav-link">${row.title}</a>
  </li>
</ul>

with this

<abt-breadcrumb items.bind="router.navigation"></abt-breadcrumb>

@shahabganji
Copy link
Contributor

I'm afraid this use case is not a match for abt-breadcrumb, but abt-navbar, since breadcrumb, is meant to show the levels of navigation you've done to reach to this point and a mechanism to be able to traverse back easily. I think what you've suggested is a better match for abt-navbar, any opinion?

ping: @HamedFathi

@khuongduybui
Copy link
Author

Ohhh my bad sorry. I have a bad example. I want to be able to supply the route href config that would come from the same place as the example. I don't literally implement it like a navbar like that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants