Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all the order's swaps in the "swap modal" #616

Open
sindresorhus opened this issue Aug 5, 2019 · 0 comments
Open

Show all the order's swaps in the "swap modal" #616

sindresorhus opened this issue Aug 5, 2019 · 0 comments

Comments

@sindresorhus
Copy link
Contributor

Read #615 first.

Currently, when you click an item in the "recent orders", we show the swap status and progress. Now that an order can have multiple swaps, we need to show all the swaps for that order. So if an order has multiple swaps, the total progress needs to reflect that and we also need to show the swap events for each swap. And we need to show whether the order is a "Taker" or "Maker" order.

For the swap events, the simplest solution would be to just reuse the UI we currently have for swap events, but have one of those for each swap, so it becomes multiple rows.

Something like this (quick idea mockup):

Untitled-1

Each row will have to show how much of the order the swap is trading in amount and percentage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant