-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: test docker build before deploying #606
Comments
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We do end-to-end tests in the CI, but the dockerfile generation is actually performed as a separate action.
What can we do to improve this?
docker
job after all other steps frommain
using theneeds
keyword. However, this still allows issues with the docker image itself (e.g. missing a port forward, or some compatibility issue with the image). Also, it might run too often this way.docker
job, run thee2e
tests after building the image, but before pushing it. This requires some changes, because currently one action does both the pushing and the building.The text was updated successfully, but these errors were encountered: