Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Long activation time #201

Open
1 task done
50Wliu opened this issue Nov 15, 2017 · 2 comments · May be fixed by #234
Open
1 task done

Long activation time #201

50Wliu opened this issue Nov 15, 2017 · 2 comments · May be fixed by #234

Comments

@50Wliu
Copy link
Contributor

50Wliu commented Nov 15, 2017

Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:

Description

Teletype is taking a long time to activate for me at around ~190ms. Looks like deferred activation isn't possible, but would it be feasible to defer some requires until they're needed? For example, until you try to host or join a portal, are the majority of requires needed?

Steps to Reproduce

  1. Enable teletype
  2. Reload atom
  3. Look at how long teletype took to activate

Expected behavior: Preferably <25ms

Actual behavior: ~190ms

Reproduces how often: 100%

Versions

Atom    : 1.24.0-dev-192cde85a
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0

Windows 10 x64.

@jasonrudolph
Copy link
Contributor

@50Wliu Thanks for logging this!

Looks like deferred activation isn't possible, but would it be feasible to defer some requires until they're needed?

Good thinking! We'd welcome contributions in this area. 😄

@50Wliu
Copy link
Contributor Author

50Wliu commented Nov 17, 2017

A quick attempt at that reveals that consumeStatusBar requires all of them anyway 😒. Will need to see if there's an easy way to defer logic in the status bar component as well.

@50Wliu 50Wliu linked a pull request Nov 17, 2017 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants