Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

marked 1.2.9 might be incompatible #1189

Open
1 task
icecream17 opened this issue Jul 15, 2021 · 0 comments
Open
1 task

marked 1.2.9 might be incompatible #1189

icecream17 opened this issue Jul 15, 2021 · 0 comments

Comments

@icecream17
Copy link
Contributor

icecream17 commented Jul 15, 2021

Prerequisites

Description

In atom/atom#22717, using marked version 1.2.0 worked, but 1.2.9 doesn't.

The fail appears to be from here:
image

Therefore the current version range ^1.2.0 includes the incompatible version 1.2.9.
Maybe it should read 1.2.0 instead, but ideally more tests with different versions would be done to see the actual range of compatibility

"marked": "^1.2.0",

Steps to Reproduce

Expected behavior:

Marked 1.2.9 works

Actual behavior:

It fails

Reproduces how often:

2/2

Versions

Atom uses settings-view v0.261.8

The tests (see atom/atom#22717 (comment)) only fail in MacOS. Weird.

Additional Information

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant