This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
src/git-repository.js line 95 #22206
icecream17
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
link: https://github.com/atom/atom/blob/master/src/git-repository.js#L95
Why is there
|| options.refreshOnWindowFocus == null
?I mean, the docs say the option is a boolean, so it doesn't matter if you set the option to a boolean.
But if you don't put the property in, it's
undefined
, which makes the conditiontrue
Maybe the doc could say "it's true by default, even if you don't provide the option parameter"
Also it's
== null
instead of=== undefined
for some reason, so I guess I'll change it to?? true
in my pr if this was intendedBeta Was this translation helpful? Give feedback.
All reactions