Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure Headers are not in use #2491

Open
mboudreau opened this issue Oct 9, 2023 · 0 comments
Open

Secure Headers are not in use #2491

mboudreau opened this issue Oct 9, 2023 · 0 comments

Comments

@mboudreau
Copy link
Contributor

mboudreau commented Oct 9, 2023

Was looking at the codebase for some stuff I've done in the past and noticed this:

setupFrontendApp(app);
secureHeaders(app);

Since it's using the express use concept, and that it's "using" after the router is setup, that means that all secure headers are essentially ignored until after the routes are completed, which means that this isn't securing anything.

I'm not sure what's being accomplished by having the security headers in a separate function since it's only used once? Why not just add it inline with all other express app settings right before the router is used?

skeletor-until-we-meet-again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant