Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fix OG Image issues of the website/app #25

Open
atapas opened this issue Sep 29, 2021 · 11 comments 路 May be fixed by #103
Open

馃悰 Fix OG Image issues of the website/app #25

atapas opened this issue Sep 29, 2021 · 11 comments 路 May be fixed by #103
Assignees
@jjung99
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest
Milestone
Hacktoberfest-21

Comments

@atapas
Copy link
Owner

atapas commented Sep 29, 2021 •
edited

Describe the bug
There is an issue with the OG image. It doesn't appear correctly when we share the web app on social media.

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://webapis-playground.vercel.app/'
  2. Share this URL on social media.
  3. The OG image doesn't appear

Expected behavior
Platforms to Test

  • Twitter
  • Kinked In

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
The fix must work for,

  • Twitter
  • Linked In
  • Reddit
  • Facebook
@atapas atapas added bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest labels Sep 29, 2021
@atapas atapas changed the title Fix OG Image issues of the website/app 馃悰 Fix OG Image issues of the website/app Sep 29, 2021
@jjung99
Copy link

jjung99 commented Sep 29, 2021

Hi, I would like to try to fix it if you are okay with it :)

@atapas atapas added this to the Hacktoberfest-21 milestone Sep 29, 2021
@atapas
Copy link
Owner Author

atapas commented Sep 29, 2021

Hi, I would like to try to fix it if you are okay with it :)

I don't mind at all. Thanks for taking it up. Let's do it.

@jjung99
Copy link

jjung99 commented Oct 4, 2021

It seems like it is working well. I don't see the issue. Here is the test screenshot.
image

@atapas
Copy link
Owner Author

atapas commented Oct 5, 2021

@jjung99 I also see that 馃槉. Have you tested the OG works well with Facebook and Reddit? If not, we still have chances to fix. Please let me know, I will close it accordingly.

Btw.. you still get the test contribution credit. Thanks for the effort.

@atapas
Copy link
Owner Author

atapas commented Oct 6, 2021

@jjung99 I also see that 馃槉. Have you tested the OG works well with Facebook and Reddit? If not, we still have chances to fix. Please let me know, I will close it accordingly.

Btw.. you still get the test contribution credit. Thanks for the effort.

Hey @jjung99 did you get a chance to test?

@jjung99
Copy link

jjung99 commented Oct 6, 2021

Here are Reddit and Facebook test screenshot.
reddit_test
facebook

So it doesn't work on Reddit.
and the image should be shown on Facebook like a Twitter screenshot?

@atapas
Copy link
Owner Author

atapas commented Oct 7, 2021

Here are Reddit and Facebook test screenshot.
reddit_test
facebook

So it doesn't work on Reddit.
and the image should be shown on Facebook like a Twitter screenshot?

That's right.

@atapas
Copy link
Owner Author

atapas commented Oct 16, 2021

Yeah, @jjung99 Would you please fix tat?

@jjung99
Copy link

jjung99 commented Oct 18, 2021

Is there a way to test it locally? I updated few lines.
branch issue-25

@atapas
Copy link
Owner Author

atapas commented Oct 18, 2021

@jjung99 You can commit your changes, Create a PR. In that PR you will find a preview URL generated to see and test your changes.

@atapas atapas linked a pull request Oct 18, 2021 that will close this issue
OG Image: updated _app.tsx #103
Open
9 tasks
@varunsood2003
Copy link

Hey @atapas is this issue still open ?
I'm new to open source and currently learning, I would love to work with you and help you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjung99 jjung99

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest
Projects
None yet
Milestone
Hacktoberfest-21
Development

Successfully merging a pull request may close this issue.

OG Image: updated _app.tsx jjung99/webapis-playground
3 participants
@atapas @jjung99 @varunsood2003