Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more templates #1

Open
aswinzz opened this issue Jan 6, 2018 · 16 comments · Fixed by #27
Open

Add more templates #1

aswinzz opened this issue Jan 6, 2018 · 16 comments · Fixed by #27
Labels
enhancement New feature or request Everyone good first issue Good for newcomers Hacktoberfest

Comments

@aswinzz
Copy link
Owner

aswinzz commented Jan 6, 2018

Everyone can work on this issue by adding more themes.
As of now there is only one template.We need more templates so that the users can have a choice among the templates.
When doing this issue:
* Create a new file theme2(or 3,4..).ejs in views folder and add the template accordingly (refer resume.ejs for embedding the json data)

@aswinzz aswinzz added Easy enhancement New feature or request good first issue Good for newcomers Rookie-10 Points OpenCode18 and removed Easy labels Jan 6, 2018
@nityanandagohain
Copy link
Contributor

I want to take this issue.

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 10, 2018

Sure

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 11, 2018

@nityanandagohain any updates?

@nityanandagohain
Copy link
Contributor

@aswinzz I am facing a problem .... i have created a theme2.ejs in views folder now where to link it please help.

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 11, 2018

send the screenshot of the page here.

@nityanandagohain
Copy link
Contributor

I have not completed it yet, but to test it how to run the .ejs file i am stuck

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 11, 2018

You have to set it up locally. Go through the readme

@nityanandagohain
Copy link
Contributor

I have already set it up .. how to access the new file from there. because selecting theme2 doesn’t seem to work

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 12, 2018

Go to routes->index.js and there will be a part where resume.js is being rendered so add a condition like if selected option is theme1 then render resume..ejs and else render theme2.ejs

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 12, 2018

So it will have solution for #5 too.so mention that when u make PR

@nityanandagohain
Copy link
Contributor

screenshot from 2018-01-12 11-01-37
Please help what is wrong here I am getting "document is not defined error" while creating CV

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 12, 2018

document.getElementById wont work ,use req.body (refer the code above that!)

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 14, 2018

@nityanandagohain status?

@nityanandagohain
Copy link
Contributor

@aswinzz I am still stuck in the JavaScript part please help me out.

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 14, 2018

okay leave that
just add the theme2.ejs and send pr
you will get points for this issue

@aswinzz
Copy link
Owner Author

aswinzz commented Jan 17, 2018

More themes are welcome!

aswinzz added a commit that referenced this issue Jan 9, 2019
Issue #1. Validation of experience and education dates + Another bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Everyone good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants