Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: int dtype comparison goes wrong linelists.cdms on Windows with astropy 6.1 #3006

Closed
bsipocz opened this issue May 9, 2024 · 1 comment · Fixed by #3008
Closed

BUG: int dtype comparison goes wrong linelists.cdms on Windows with astropy 6.1 #3006

bsipocz opened this issue May 9, 2024 · 1 comment · Fixed by #3008
Labels
bug cdms

Comments

@bsipocz
Copy link
Member

bsipocz commented May 9, 2024

The CI failures seem to uncover some actual bugs. While running the tests locally on an OSX passes everything, I do see the bug if directly passing a non-string to parse_letternumber.
@bsipocz
Copy link
Member Author

bsipocz commented May 9, 2024

OK, diving into the code, the function is likely all good, but the conditional prior to its calling is wrong. I suspect astropy/astropy#16005 may be the cause, but I'm not certain as I cannot debug it locally (it only shows on windows).

I'll try a few things in a PR, and maybe will hit a solution that works.

@bsipocz bsipocz mentioned this issue May 9, 2024
Merged
@bsipocz bsipocz changed the title BUG: duck-typing goes wrong in parse_letternumber() in linelists.cdms BUG: int dtype comparison goes wrong linelists.cdms on Windows with astropy 6.1 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cdms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: changing int comparison to fix incompatibility with astropy 6.1 bsipocz/astroquery
1 participant
@bsipocz