Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support docs generated with dbt docs generate --static #986

Closed
dwreeves opened this issue May 17, 2024 · 1 comment
Closed

Support docs generated with dbt docs generate --static #986

dwreeves opened this issue May 17, 2024 · 1 comment
Labels
area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality good first issue Good for newcomers
Milestone
Cosmos 1.5.0

Comments

@dwreeves
Copy link
Collaborator

Right now the docs do not support docs generated with --static.

All that should be needed for this is searching for static_index.html in addition to searching for index.html in the path provided by the user; only return a 404 in the event that either cannot be found.
@dwreeves dwreeves added good first issue Good for newcomers dbt:docs Primarily related to dbt docs command or functionality labels May 17, 2024
@dwreeves dwreeves added this to the Cosmos 1.5.0 milestone May 17, 2024
@dosubot dosubot bot added the area:docs Relating to documentation, changes, fixes, improvement label May 17, 2024
@dwreeves dwreeves mentioned this issue May 27, 2024
Merged
2 tasks
tatiana pushed a commit that referenced this issue Jun 10, 2024
@dwreeves
support static_index.html docs (#999)
74c28e2 
- Support `static_index.html` for dbt docs.
- Refactor remote filesystem access functions in anticipation of moving
them out of `cosmos/plugins/__init__.py`. Refactoring is designed to
make them behave a little more predictably and to make them look a
little more like Airflow 2.8+'s `ObjectStoragePath` class. Of course,
this is far, far from complete.

# Related Issue(s)

- Main: #986
- Related: #927
@dwreeves
Copy link
Collaborator Author

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality good first issue Good for newcomers
Projects
None yet
Milestone
Cosmos 1.5.0
Development

No branches or pull requests
1 participant
@dwreeves