Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook to be called after cosmos task execution #976

Open
SiddiqueAhmad opened this issue May 17, 2024 · 1 comment
Open

Hook to be called after cosmos task execution #976

SiddiqueAhmad opened this issue May 17, 2024 · 1 comment
Assignees
Labels
dbt:test Primarily related to dbt test command or functionality epic-assigned
Milestone

Comments

@SiddiqueAhmad
Copy link
Contributor

To pipe dbt test results.json, We need to register hook with results so users can use it for further integration. We need this for integration with openmetadata for data quality.

@dosubot dosubot bot added the dbt:test Primarily related to dbt test command or functionality label May 17, 2024
@tatiana
Copy link
Collaborator

tatiana commented May 17, 2024

Thanks a lot, @SiddiqueAhmad , for writing down this!

Giving further context, this came from a discussion in Slack #airflow-dbt: https://apache-airflow.slack.com/archives/C059CC42E9W/p1715857421750369

It is a valid use case, and we don't have an out-of-the-box solution at the moment.

Similar to how we're handling on_warning_callback:

if self.on_warning_callback and number_of_warnings > 0:

We could have a mechanism for users to define a function that would be called after Cosmos tasks are executed and that could receive the result/context. I believe, ideally, this function would affect all (at least Local/VirtualEnv) Cosmos Operators. This may solve the problem described in #903.

Did you check with your team if someone would be available/interested in implementing this, @SiddiqueAhmad ?

@tatiana tatiana added this to the 1.5.0 milestone May 17, 2024
@tatiana tatiana added the triage-needed Items need to be reviewed / assigned to milestone label May 17, 2024
@tatiana tatiana removed the triage-needed Items need to be reviewed / assigned to milestone label May 17, 2024
@tatiana tatiana modified the milestones: Cosmos 1.5.0, Cosmos 1.6.0 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt:test Primarily related to dbt test command or functionality epic-assigned
Projects
None yet
Development

No branches or pull requests

3 participants