-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfolding sometimes results into concatenated channels #627
Comments
Thanks for the issue, that's very informative ! |
So, right now there are two simple ways of unfolding a tensor. cheers |
Thanks for the explanation @markusMM Could you submit a PR to fix the problem please ? 🙃 Thanks in advance ! |
asteroid/asteroid/dsp/overlap_add.py
Line 92 in c72227e
/We can see how torch 1.10.2 does concatenates the windows of all channels after unfold./
The expected behavior, in the code, would be to handle
$\rightarrow$
(batch, chans, win_size)
per chunk(batch, chans, win_size, n_chunks)
.Thus it has to be reshaped before handling to the NN, from my perspective.
unfolded = unfolded.reshape(batch, channels, self.window_size, -1)
The text was updated successfully, but these errors were encountered: