Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additionalPropertiesDefaultValue implementation bug #244

Open
amvFrontendMonkey opened this issue Nov 7, 2023 · 3 comments
Open

additionalPropertiesDefaultValue implementation bug #244

amvFrontendMonkey opened this issue Nov 7, 2023 · 3 comments

Comments

@amvFrontendMonkey
Copy link

amvFrontendMonkey commented Nov 7, 2023 •
edited

In the PR - https://github.com/astahmer/openapi-zod-client/pull/230/files - the cli switch --additional-props-default-value false is not coerced into a boolean before the check within openApiToZod.ts (const additionalPropsSchema = additionalProps === false ? "" : ".passthrough()";)
@astahmer
Copy link
Owner

astahmer commented Nov 7, 2023

would you like to send a PR ?

@amvFrontendMonkey
Copy link
Author

ah, this is a work account and i'm not on the project anymore.

Sorry to say then, I won't

@amvFrontendMonkey
Copy link
Author

amvFrontendMonkey commented May 9, 2024 •
edited

@astahmer I'd be willing to provide a PR for this

Is this something you'd accept?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astahmer @amvFrontendMonkey