Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of images in cache #2

Open
OrkoHunter opened this issue Sep 15, 2016 · 1 comment
Open

Number of images in cache #2

OrkoHunter opened this issue Sep 15, 2016 · 1 comment

Comments

@OrkoHunter
Copy link

Hey,

When I ran catimg for the first time, it said No cat images found, downloading.... And then it started the non-stop download process.

Basically, I felt there should be a prompt asking me about how many images to store or the total memory size to use for the images. Suggestions?

@asmeurer
Copy link
Owner

By default it downloads all the images that imgurpython returns, which I think is all the images from a page of search results. The total size depends on how large the images are at that point in time (it tends to be dominated by some large gifs).

I personally don't mind. My hard drive is large and my internet is fast. I implemented caching so that it works offline, and, more importantly, so that it works immediately. I have it at the top of my bash profile and when I open a terminal tab I don't want to wait for an image to download from the internet.

But I can see why it might bother others. My cache right now is 290 MB.

I'm happy to accept a PR implementing some solution to this. If there is a prompt, it should write the answer to disk so that it doesn't ask every time. Maybe command line flags as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants