Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow click on overlay to exit without running callback assuming false #11

Open
adamtarmstrong opened this issue Jul 23, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@adamtarmstrong
Copy link

Is your feature request related to a problem? Please describe.
I would like to use this component more as a 2 option dialog (rather than a yes/no). Currently, if you click on the overlay then it behaves as "false" and runs the callback w/ false.

Describe the solution you'd like
I'd like clicking on the overlay to simply close the entire component without actually making a "no" selection.

Describe alternatives you've considered
The simplest solution would be to remove the callback on line 103, inside the method handleClickOverlay(). Or a more dynamic solution would be to allow you to define a separate onCancelCallback() to be used at init.

Additional context
Thanks for considering this. Making this change would allow for backwards compatibility while providing a huge improvement in a small area.

@aslanon aslanon self-assigned this Aug 25, 2020
@aslanon aslanon added the bug Something isn't working label Aug 25, 2020
@aslanon
Copy link
Owner

aslanon commented Aug 25, 2020

Thanks. I am working on this bug.

@aviramha
Copy link

aviramha commented Nov 5, 2020

Any update on this?

@yourcharlie23
Copy link

Any update?

@lamanhdai
Copy link

any updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants