Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not support whitelists #127

Open
cfontes opened this issue Oct 15, 2018 · 2 comments
Open

Plugin does not support whitelists #127

cfontes opened this issue Oct 15, 2018 · 2 comments

Comments

@cfontes
Copy link

cfontes commented Oct 15, 2018

Would be nice to support white lists, specially with variable interpolation from environment variables in the material.

BTW, thanks for the plugin

@ashwanthkumar
Copy link
Owner

@cfontes A few questions so I understand this better

  • By Whitelists, do you mean white-listing on the branches or whitelisting on the paths in the repo that can trigger the build? If it's branches, Git Feature Branches already support it today.
  • If you're asking for white-listing the branches in other plugins (apart from FB plugin), can you please explain the use-cases where it might be used?

PS: We can't have environment variable based interpolation, but it should be possible to use Parameters.

@schweikert
Copy link

What about whitelisting on the paths in the repo? Is that possible/planned?

We have multiple independent components in the same git repo, and and without directory whitelisting support all the components are rebuild/retested every time, which wastes gocd agent resources and also increases the time that the PR becomes ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants