Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: loss function improvement #606

Closed
wants to merge 2 commits into from
Closed

feat: loss function improvement #606

wants to merge 2 commits into from

Conversation

Mai0313
Copy link

@Mai0313 Mai0313 commented Oct 2, 2023 •
edited

What does this PR do?

  • Change loss function to be list, then using loop to record everything
  • Allow users to enter a weight for multiple loss functions.

Fixes #605

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bddbc24) 83.24% compared to head (d4f06d4) 83.92%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   83.24%   83.92%   +0.68%     
==========================================
  Files          11       12       +1     
  Lines         376      392      +16     
==========================================
+ Hits          313      329      +16     
  Misses         63       63
Files Coverage Δ
src/models/components/loss_fn.py 100.00% <100.00%> (ø)
src/models/mnist_module.py 97.26% <100.00%> (+0.29%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mai0313 Mai0313 closed this by deleting the head repository Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion with Solution about loss function
2 participants
@Mai0313 @codecov-commenter