Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch mode on ESM #239

Open
danny-waite opened this issue Sep 25, 2023 · 3 comments · May be fixed by #241
Open

Watch mode on ESM #239

danny-waite opened this issue Sep 25, 2023 · 3 comments · May be fixed by #241

Comments

@danny-waite
Copy link

I noticed watch mode isn't support for ESM however commenting out the check seems to work at first glance.

console.log("Watch mode not supported for ECMAScript lambda modules.");

Before I go deeper and potentially submit a PR, I was wondering why this was added?

@gpotter2
Copy link
Collaborator

It's not tested, so it's not supported :)

@danny-waite
Copy link
Author

ah ok, makes sense :)

Any suggestions on how we test and get this supported?

@gpotter2
Copy link
Collaborator

Feel free to submit a PR that tests this. There are already other watch tests

@micaww micaww linked a pull request Oct 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants