-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to get accept_languages instead of user_agent.language #62
Comments
Thank you for the kind words @Ben-Bock! That sounds like a good idea. What are your thoughts on priority of the fields? Should it be |
Hi, that makes sense to only go for the accepted if the other is not set explicit. |
Sounds good. I'll take a look at this. |
I've started to look at how to plumb this through storage. Would you be up for helping test once I have some code up for review? |
Hi, yes sure, happy to test that once it's available. |
I haven't forgot about this :-) I should have some code up near the end of the week. |
Thank you so much for creating this great package!
When I'm using it in most of the cases the ua_language is empty.
I think it's because of the usage of request.user_agent.language instead of request.accept_languages.
Browsers don't so often set the language but the accepted lanuages should be there nearly every time.
A change here may be a very great thing.
Thank you so much!
The text was updated successfully, but these errors were encountered: