Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use python2 in the build instructions? #7

Open
dacap opened this issue May 25, 2020 · 6 comments
Open

Should we use python2 in the build instructions? #7

dacap opened this issue May 25, 2020 · 6 comments

Comments

@dacap
Copy link
Member

dacap commented May 25, 2020

Should we use python2 in the build instructions and workflow file?

Related to: aseprite/aseprite#2090

@dacap
Copy link
Member Author

dacap commented May 29, 2020

Not sure about this one, on Windows if I use python2 I got this error:

C:\deps\skia>python2 tools/git-sync-deps
'python2' is not recognized as an internal or external command,
operable program or batch file.

While python works correctly.

@alvinseptiano
Copy link

alvinseptiano commented Jun 4, 2020

so that i was using the wrong version of python?
im using ubuntu when im typing python it's using python2
you have to explicitly type python3 to use python3 and i thought it was using python2..

@dacap
Copy link
Member Author

dacap commented Jun 4, 2020

Skia uses/needs python 2. In my previous comment I said that we must use python (it should be pointing to python 2), but we cannot use python2 in the command line because it's not included in the Skia's depot_tools. Just a detail.

@ryandesign
Copy link

The aseprite-m81 branch of skia in this repo seems to build fine for me using python 3.9.

@ryandesign
Copy link

The aseprite-m81 branch of skia in this repo seems to build fine for me using python 3.9.

I was mistaken; #22 is an example of failure when using python 3.

@dacap
Copy link
Member Author

dacap commented Apr 26, 2022

I think the biggest problem is that depot_tools is a "living thing" where Google updates for new Skia & Chrome, versions. I think they switched to Python 3 recently (but I might be wrong). Probably the best thing to do would be to update Skia to the latest version so it can use the latest depot_tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants