Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore any third-party theme that uses "default" as ID #4226

Open
dacap opened this issue Dec 14, 2023 · 2 comments · May be fixed by #4335
Open

Ignore any third-party theme that uses "default" as ID #4226

dacap opened this issue Dec 14, 2023 · 2 comments · May be fixed by #4335
Assignees
@Gasparoken
Labels
bug high priority time-2
Milestone
v1.3.7

Comments

@dacap
Copy link
Member

dacap commented Dec 14, 2023

From ticket: https://igarastudio.zendesk.com/agent/tickets/5545

We must limit/ignore any theme extension that wants to replace the default theme and is not the official one installed in the data directory (this might be harder to detect in portable versions of Aseprite).
@dacap dacap added this to the v1.3.3 milestone Dec 14, 2023
@Gasparoken Gasparoken self-assigned this Jan 25, 2024
@Gasparoken
Copy link
Member

I was able to reproduce the crash. The aseprite-theme corresponds to an old version of Aseprite, some "styles" were missing. The crash was due to some style pointers being nullptr.
So @dacap what is your opinion on the following approach?:

If any style pointer is nullptr, the aseprite startup process is suspended and an alert is displayed:
The "aseprite-theme" is corrupted or outdated; Delete this file and reinstall Aseprite.

Alternatives:

  • Calculate checksum of aseprite-theme files and compare with a precalculated checksum. If it does not match -> same alert as above.
  • Regenerate aseprite-theme files every time Aseprite is started (from code embedded within the binary).

@dacap dacap modified the milestones: v1.3.3, v1.3.4, v1.3.5 Feb 14, 2024
@Gasparoken
Copy link
Member

As a first approach, I'm trying to give a default style to the missing theme styles. If I succeed with a solution, it will be the solution for #4015

Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Feb 23, 2024
@Gasparoken
Fix Ignore any third-party theme that uses "default" as ID (fix asepr…
96b8ed0 
…ite#4226)

This fix hides user themes whose name is the same as the default,
that is, "aseprite-theme" and are present in the user folders (i.e.
'extensions' and 'data/themes' folders).
@Gasparoken Gasparoken linked a pull request Feb 23, 2024 that will close this issue
Open
@dacap dacap modified the milestones: v1.3.5, v1.3.6 Feb 28, 2024
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Mar 1, 2024
@Gasparoken
Fix Ignore any third-party theme that uses "default" as ID (fix asepr…
7111683 
…ite#4226)

This fix hides user themes whose name is the same as the default,
that is, "aseprite-theme" and are present in the user folders (i.e.
'extensions' and 'data/themes' folders).
@dacap dacap modified the milestones: v1.3.6, v1.3.7 Apr 9, 2024
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Apr 10, 2024
@Gasparoken
Fix Ignore any third-party theme that uses "default" as ID (fix asepr…
5d49a03 
…ite#4226)

This fix hides user themes whose name is the same as the default,
that is, "aseprite-theme" and are present in the user folders (i.e.
'extensions' and 'data/themes' folders).
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Apr 16, 2024
@Gasparoken
Fix do not allow to install theme with the same content of the defaul…
2adfd0b 
…t aseprite-theme (fix aseprite#4226)
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Apr 16, 2024
@Gasparoken
Fix do not allow to install theme with the same content of the defaul…
af5b30a 
…t aseprite-theme (fix aseprite#4226)
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Apr 16, 2024
@Gasparoken
Fix do not allow to install theme with the same content of the defaul…
99de589 
…t aseprite-theme (fix aseprite#4226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gasparoken Gasparoken

Labels
bug high priority time-2
Projects
Aseprite v1.3.x
Status: Done
Milestone
v1.3.7
Development

Successfully merging a pull request may close this issue.

Fix Ignore any third-party theme that uses "default" as ID (fix #4226) Gasparoken/aseprite
3 participants
@dacap @martincapello @Gasparoken