Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install script assumes path of asdf #361

Open
zrusilla opened this issue Jul 29, 2023 · 2 comments
Open

install script assumes path of asdf #361

zrusilla opened this issue Jul 29, 2023 · 2 comments

Comments

@zrusilla
Copy link

In plugins/nodejs/bin/install, the invocation of asdf reshim assumes that it is findable on the PATH, which may not always be the case.

asdf reshim "$(plugin_name)" "$ASDF_INSTALL_VERSION"

I was able to work around it by modifying ../lib/utils.sh to export ASDF_DIR:

export ASDF_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")/../../.." && pwd)

and prepending the path to asdf in install:

$ASDF_DIR/bin/asdf reshim "$(plugin_name)" "$ASDF_INSTALL_VERSION"

I will submit a patch for this if you like.

@augustobmoura
Copy link
Member

augustobmoura commented Aug 24, 2023

On which occasions would asdf not be on PATH?

@matmatias
Copy link

On which occasions would asdf not be on PATH?

When installing asdf and nodejs via script, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants