make mix binary executable #130
Conversation
There was a problem hiding this comment.
This file isn't the mix binary. It's a shim template that's only read by asdf to generate the actual mix shim that invokes the binary. I don't see any good reason for a template to be executable. rtx should probably handle generating an executable file if that is necessary.
See https://asdf-vm.com/plugins/create.html#custom-shim-templates
|
@Stratus3D I'm curious if you've considered if we could remove shim templates, couldn't the plugin's install script just copy this to |
|
Sorry for the late reply here.
Yes, I think it could but I've not tested it. Shim templates were added early on I believe and they never became a widely used feature. In this case it looks like it's probably not needed, but other plugins may still rely on shim templates. I'm going to close this PR as I don't want shim templates to be executable. |
Fixes #129