Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD vs Imagick - required vs optional #2

Open
Moc opened this issue Feb 21, 2019 · 1 comment
Open

GD vs Imagick - required vs optional #2

Moc opened this issue Feb 21, 2019 · 1 comment
Labels
Type: Bug Something isn't working

Comments

@Moc
Copy link

Moc commented Feb 21, 2019

I just installed the plugin on one of my installations where GD was installed/configured, but Imageick wasn't.

As Imagick is listed as required extension in plugin.xml, e107 wouldn't let me install the plugin (Error: "Required PHP extension not loaded").

Now if I understand correctly, the plugin works as long as one of the two is installed. After removing Imagick from the plugin.xml, I could install the plugin just fine and it worked properly.

I am not sure how to fix this, perhaps we need to add something in e107 core to allow for these kind of configurations where one requirement is optional if the other is installed (and vice-versa).

Oh, and thank you for your great plugins. They make life so much easier 😄 👍

@arunshekher
Copy link
Owner

@Moc, Thank you & Sorry to respond late. Yes you are right, either one is enough for the plugin to function.

Yes a plugin.xml configuration declaration that allows either one the requirement from a given set will be a welcome addition.

I’ll remove this xml declaration from next release. 👍🏼

@arunshekher arunshekher added the Type: Bug Something isn't working label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants