Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some text are invisible (same as background color) #32

Open
tolgaek opened this issue Sep 12, 2013 · 29 comments
Open

Some text are invisible (same as background color) #32

tolgaek opened this issue Sep 12, 2013 · 29 comments

Comments

@tolgaek
Copy link

tolgaek commented Sep 12, 2013

So because the 9th color in the palette is Base03 which is the same as the background, so now in a lot of my log outputs or test results and so on, that color is used..

The issue is that I can change that color in the palette but then my vim background color is that same color because of the fact that when you do background=dark in VIM, it seems to use that 9th color in the palette..

Any ideas on how I can handle both cases?

@aruhier
Copy link
Owner

aruhier commented Sep 12, 2013

Hello,
Could you join a screenshot please ?

@tolgaek
Copy link
Author

tolgaek commented Sep 12, 2013

Below is the output with hidden text
invisible

Now in the exact same screen if I change 9th color of the palette, i get this;
visible

@aruhier
Copy link
Owner

aruhier commented Sep 12, 2013

This is weird, it never happened on my vim...

Have you tried with a clean gnome-terminal profile ?

@sigurdga
Copy link
Collaborator

I can confirm that the colors are the same. I have seen this when running javascript tests, and I change to the light background when it is a problem. But I'm sure we can get into the same situation for a light background as well.

I think this has to be changed where the colors are set, in dircolors.

@blueyed
Copy link

blueyed commented Oct 9, 2013

Well, BASE03 gets used both for the background and the 9th entry in the PALETTE.

PALETTE = [BASE02, RED, GREEN, YELLOW, BLUE, MAGENTA, CYAN, BASE2,
           BASE03, ORANGE, BASE01, BASE00, BASE0, VIOLET, BASE1, BASE3]
SCHEMES = {'dark': {'background_color': BASE03,
                    'foreground_color': BASE0,
                    'bold_color': BASE1},

For me it's btw "gray" (from Zsh's $fg array) which is also mapped to "black".

@Anthony25 it's not about Vim here, but gnome-terminal.

It's also a problem with Terminator [1], which has a built-in scheme "Solarized black" (when using the Solarized palette also).

1: http://gnometerminator.blogspot.de/p/introduction.html

@fearphage
Copy link

I can confirm this and I'm seeing it in the same use case (running unit tests). What'd you change the color to for the second screenshot?

@sigurdga
Copy link
Collaborator

This seems we will have problems like this with coloured outputs using solarized. altercation/solarized#220 describes several tools outputting grey and giving problems like this. Solarized may need a fix that will be hard to implement because of the use grey background. In the mentioned issue, you can find links to a fork that may work for you.

absynce added a commit to absynce/gnome-terminal-colors-solarized that referenced this issue Apr 29, 2014
@aruhier
Copy link
Owner

aruhier commented Jun 3, 2014

Fixed with ff1e664, thanks to @absynce.

@armyofzin
Copy link

Was the intent to change the background color? My background is all washed out now. i.e. BASE01.

@aruhier
Copy link
Owner

aruhier commented Jun 11, 2014

I didn't see the difference that's why I pulled this commit because it seems to fix the invisible text without changing anything. If you prefered the old color, I revert the commit.

@aruhier aruhier reopened this Jun 11, 2014
@sigurdga
Copy link
Collaborator

The old color is the correct color. The invisible output is a bug between the other libs. (Solarized has too few colors for the other tools… or something like that)

@aruhier
Copy link
Owner

aruhier commented Jun 11, 2014

Okay I see, sorry about that. I'm reverting the commit.

aruhier added a commit that referenced this issue Jun 11, 2014
This reverts commit ff1e664.
Not the correct color in fact
@aruhier aruhier closed this as completed Jun 11, 2014
@jmatth
Copy link

jmatth commented Jun 18, 2014

This is a pretty well known bug in the Solarized palette. I found a way to fix it but it breaks compatibility with any programs like vim that have a Solarized colorscheme. Here's my writeup on the fix. Sorry for the shameless self-plug, but as far as I can tell nobody has come up with another solution yet.

@blueyed
Copy link

blueyed commented Jun 18, 2014

FWIW, here is a simple script to output a table of all colors, which might help to address this issue: https://github.com/blueyed/dotfiles/blob/master/usr/bin/colors-table
You can use it as colors-table - to get all colors without / on transparent background.

@jmatth
Copy link

jmatth commented Jun 19, 2014

Here's a comparison with upstream solarized, solarized with base03 changed (like how everyone tries to fix it), the problem that causes in vim, and vim with the transparency fix applied:

solarized_graphic

@blueyed
Copy link

blueyed commented Jul 2, 2014

gnome-terminal allows setting a different text and background color (which must not be in the palette).

Can't this be used? The palette would stay the same (and no changes to the Vim (and other apps') colorscheme would be needed), but gnome-terminal would use a slightly different background color.

Also, please re-open this issue.

@aruhier
Copy link
Owner

aruhier commented Jul 2, 2014

Well, this script respects the solarized colorsheme, and I have exactly the same problem with urxvt (that I have solved in installing the solarized theme for vim). The question is : do you prefer having a terminal with the solarized colors and a vim which needs the solarized theme, or a terminal with a different background than the solarized one, with a vim less broken (but still uglier than with the solarized vim theme) ?

@aruhier aruhier reopened this Jul 2, 2014
@blueyed
Copy link

blueyed commented Jul 3, 2014

I am using the solarized theme for Vim (cherry-picked fixes from other forks; https://github.com/blueyed/vim-colors-solarized), and it appears to work fine with gnome-terminal-colors-solarized.
I am only trying to improve the issue, where you might end up with invisible text in the terminal.
Having a different background would work around this.
It should not affect the Vim colorscheme, because this would use the (unchanged) palette.

@aruhier
Copy link
Owner

aruhier commented Jul 16, 2014

Which color do you suggest for the background ?

@absynce
Copy link
Contributor

absynce commented Jul 16, 2014

I have both the vim solarized theme and the gnome-terminal solarized theme. There are no adverse affects to using this combination that I see with the changes I made in ff1e664. @armyofzin @sigurdga, what combination of themes/configurations causes issues for you?

@sgon00
Copy link

sgon00 commented Aug 2, 2014

Hi, I got a similar problem. I installed this theme yesterday. I am using dark theme with dircolors.ansi-dark. In htop program, the percentage numbers are invisible when this theme profile is selected in gnome-terminal. When I change the profile to the default one, they become visible again.

@sgon00
Copy link

sgon00 commented Aug 2, 2014

Here is the screenshot:

@aruhier
Copy link
Owner

aruhier commented Aug 2, 2014

Hello @sgon00,
until we find a replacement color for the background, you can switch on the "black night" theme in htop.

@sgon00
Copy link

sgon00 commented Aug 2, 2014

Hello @Anthony25, thanks a lot for the suggestion. I never know I can change htop color theme before. Just found out in F2 setup menu of htop. The background color is cool to me. I am using solarized theme everywhere. Thanks.

@aruhier
Copy link
Owner

aruhier commented Aug 2, 2014

I like it too, the problem is that 2 colors are identical, and some soft like htop or vim are using these 2 colors to contrast. It's an upstream bug, directly linked with the official solarized color-scheme...

aruhier added a commit that referenced this issue Aug 20, 2014
This reverts commit ff1e664.
Not the correct color in fact
daniel-fanjul-alcuten added a commit to daniel-fanjul-alcuten/dotfiles that referenced this issue Oct 16, 2014
 * usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17):
   > Adapt the README to the last commits
   > Fix bug with gconf
   > Project more modular
   > set_dark and set_light apply theme for default theme
   > Complete the README
   > Remove unnecessary files
   > Adapt help to the new colors modifications
   > Profiles standardisation
   > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files
   > Remove the 80 chars/l splitting
   > Fix typo in README
   > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32"
   > Merge https://github.com/sveiss/gnome-terminal-colors-solarized
   > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32
   > Invite anybody to make a fork for Mate
   > Move the python script in a branch
   > Merge pull request #41 from sveiss/fix-quoting
@anjosh-zz
Copy link

@jmatth your fix worked for me so far. Thanks a lot!

@j-hannes
Copy link

j-hannes commented Jan 6, 2016

The text will be visible if you set iterm2's contrast a little bit higher. Go to Preferences > Profiles > Colors > Minimum contrast and set the slider a little bit to the right and you will see the invisible text. (Also see https://www.iterm2.com/documentation-one-page.html, search for "contrast".)

Even tho not a solution to the actual problem this might help most people who run into the same problem. ;)

@blueyed
Copy link

blueyed commented Jan 6, 2016

JFI: while I am not using gnome-terminal for a while already, I've switched to using base16 recently, and it has profiles for gnome-terminal, too: https://github.com/chriskempson/base16-gnome-terminal

Together with https://github.com/chriskempson/base16-shell (and a modified colorscheme for Vim (https://github.com/blueyed/vim-colors-solarized) this seems to be a good fix for me.
I am using rxvt-unicode / urxvt with the Xresources settings from base16.

daniel-fanjul-alcuten added a commit to daniel-fanjul-alcuten/dotfiles that referenced this issue Oct 1, 2016
 * usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17):
   > Adapt the README to the last commits
   > Fix bug with gconf
   > Project more modular
   > set_dark and set_light apply theme for default theme
   > Complete the README
   > Remove unnecessary files
   > Adapt help to the new colors modifications
   > Profiles standardisation
   > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files
   > Remove the 80 chars/l splitting
   > Fix typo in README
   > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32"
   > Merge https://github.com/sveiss/gnome-terminal-colors-solarized
   > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32
   > Invite anybody to make a fork for Mate
   > Move the python script in a branch
   > Merge pull request #41 from sveiss/fix-quoting
daniel-fanjul-alcuten added a commit to daniel-fanjul-alcuten/dotfiles that referenced this issue Oct 30, 2016
 * usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17):
   > Adapt the README to the last commits
   > Fix bug with gconf
   > Project more modular
   > set_dark and set_light apply theme for default theme
   > Complete the README
   > Remove unnecessary files
   > Adapt help to the new colors modifications
   > Profiles standardisation
   > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files
   > Remove the 80 chars/l splitting
   > Fix typo in README
   > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32"
   > Merge https://github.com/sveiss/gnome-terminal-colors-solarized
   > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32
   > Invite anybody to make a fork for Mate
   > Move the python script in a branch
   > Merge pull request #41 from sveiss/fix-quoting
daniel-fanjul-alcuten added a commit to daniel-fanjul-alcuten/dotfiles that referenced this issue Oct 30, 2016
 * usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17):
   > Adapt the README to the last commits
   > Fix bug with gconf
   > Project more modular
   > set_dark and set_light apply theme for default theme
   > Complete the README
   > Remove unnecessary files
   > Adapt help to the new colors modifications
   > Profiles standardisation
   > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files
   > Remove the 80 chars/l splitting
   > Fix typo in README
   > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32"
   > Merge https://github.com/sveiss/gnome-terminal-colors-solarized
   > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32
   > Invite anybody to make a fork for Mate
   > Move the python script in a branch
   > Merge pull request #41 from sveiss/fix-quoting
@exarus
Copy link

exarus commented Apr 29, 2018

@anjosh @jmatth
I read the article but it's a bit too hard for me. What exactly can I do to see light gray in my Ubuntu 18.04 Gnome Terminal?

daniel-fanjul-alcuten added a commit to daniel-fanjul-alcuten/dotfiles that referenced this issue Aug 22, 2018
 * usr/share/gnome-terminal-colors-solarized d9fcb57...84d885c (17):
   > Adapt the README to the last commits
   > Fix bug with gconf
   > Project more modular
   > set_dark and set_light apply theme for default theme
   > Complete the README
   > Remove unnecessary files
   > Adapt help to the new colors modifications
   > Profiles standardisation
   > New color palettes to fix colors in gnome terminal. Madea backup of old palettes in the colors/.palette*_backup files
   > Remove the 80 chars/l splitting
   > Fix typo in README
   > Revert "Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32"
   > Merge https://github.com/sveiss/gnome-terminal-colors-solarized
   > Fix hidden text with BASE03 by replacing with BASE01. For aruhier/gnome-terminal-colors-solarized#32
   > Invite anybody to make a fork for Mate
   > Move the python script in a branch
   > Merge pull request #41 from sveiss/fix-quoting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests